hyper-tabs-enhanced icon indicating copy to clipboard operation
hyper-tabs-enhanced copied to clipboard

Use hyper-tab-icons internally?

Open TrevorBurnham opened this issue 7 years ago • 3 comments

The hyper-tab-icons plugin supports a more comprehensive set of icons, as well as more mappings for alternative process names and support for custom mappings.

I like the other enhancements provided by hyper-tabs-enhanced, so I wonder if it would be possible for this project to integrate hyper-tab-icons, rather than compete with it for the same functionality.

TrevorBurnham avatar Feb 27 '17 19:02 TrevorBurnham

@TrevorBurnham

Problem with just dropping support for tab icons in favor of hyper-tab-icons is that people would have to find both plugins. Since there's currently no easy way to have a plugin depend on another. If hyper-tab-icons creator were open to merge the plugins I wouldn't mind collaborating on that.

If there's any icons you're missing I'll gladly add them, just let me know ✌️

PR #6 adds support for mapping, I just haven't had time to fully look at it and I also want to refactor some of that code before merging.

henrikruscon avatar Mar 03 '17 20:03 henrikruscon

I can expose an API for this plugin to consume if it makes things easier.

dfrankland avatar Mar 13 '17 03:03 dfrankland

Why, precisely, should this depend on hyper-tab-icons? Honestly, this could/should be smaller and more granular, provide less functionality. Users can find the other package if they want that specific functionality.

Seems to me that a mention in the README (as with the status-line mention, etc) is more than enough? Just my 2¢.

ELLIOTTCABLE avatar Jul 17 '17 07:07 ELLIOTTCABLE