hyper-tabs-enhanced
hyper-tabs-enhanced copied to clipboard
henrikruscon
Support opacity for background tabs
I'm using a hyper config where my window is transparent and vibrant:
hyper-tabs-enhanced sets the background tab to opaque black, instead of a darker but still transparent look that I would expect. Perhaps for transparent black tabs, it should just increase background tab opacity?
Ah, so it is. I think it's darker than I'd like, though, could there be a config option for "degree of darkening?" Maybe I'll work on a PR?
If there's a way to detect vibrancy and then based on that darken the color less, that would be ideal.
https://github.com/matheuss/hyper-simple-vibrancy/blob/master/index.js#L1 sets the vibrancy inside the onwindow method, I'm not sure whether it's possible to access browserWindow outside of this.
It is but I can't see that it holds the vibrancy variable. I'm gonna look into it more
If there's a setVibrancy method I'd assume there was a corresponding getVibrancy method
Yeah, sadly there isn't. https://github.com/electron/electron/blob/master/docs/api/browser-window.md#winsetvibrancytype-macos
I've got a lot of work so I won't be able to look into this for like 3 days ✌️
That's fine, there's no rush On Tue, Feb 21, 2017 at 8:37 AM Henrik [email protected] wrote:
I've got a lot of work so I won't be able to look into this for like 3 days ✌️
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/henrikdahl/hyper-tabs-enhanced/issues/7#issuecomment-281346261, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ5Yr_kNiwSgDc7KXL-322ds9pUWfyq2ks5reuirgaJpZM4MGdLq .
Can confirm I get this as well. As much as I enjoy the unique features of this plugin I can't help but feel its too opinionated. It changes colors of my background, my inactive tabs and also interferes with icons. I guess its a combo plugin that sits well with the author and that's cool too.
