hyper-statusline icon indicating copy to clipboard operation
hyper-statusline copied to clipboard

[email protected] breaks styles

Open brandonweiss opened this issue 8 years ago • 8 comments

I'm pretty sure some CSS selectors must have changed or something… I updated to the latest version of Hyper and the status line looks like this now.

screen shot 2017-09-05 at 11 23 25 am

brandonweiss avatar Sep 05 '17 18:09 brandonweiss

@brandonweiss I solved this problem.

  1. I relocated plug-in from directory node_modules to local.
  2. I modified the configuration in the .hyper.js file accordingly.
  3. I installed missing modules (tildify after-all-results) for hyper-statusline to node_modules directory (via yarn/npm).

Looks like it's working right now again properly.

screen shot 2017-09-26 at 17 44 11

kajka avatar Sep 26 '17 15:09 kajka

@kajka By “solved” you mean you figured out how to temporarily make it work for you locally, yes? Do you know what the actual problem/solution is? Like is it just some undeclared dependencies?

brandonweiss avatar Oct 02 '17 23:10 brandonweiss

No I don't now what actual problem is. Unfortunately, the solution is not permament :(.

kajka avatar Nov 06 '17 15:11 kajka

Are you sure hyper-statusline is listed after your theme in plugins? ✌️

henrikruscon avatar Dec 05 '17 02:12 henrikruscon

Unfortunately no. I use my own theme, which is located in localPlugins. Indeed, this can be an issue; when I add different theme under plugins section, hyper-statusline plugins works fine!

kajka avatar Dec 05 '17 20:12 kajka

There's really not much that can be done here by hyper-statusline since that's how Hyper handles plugins. hyper-statusline cannot fetch theme colors unless the theme has already been loaded.

What you could do is run hyper-statusline locally as well but that's not ideal I guess ✌️

henrikruscon avatar Dec 06 '17 00:12 henrikruscon

@henrikdahl Jaysus, that was the problem? I had no idea themes needed to be loaded before plugins… that's so brittle. How are people not constantly running into this problem?

brandonweiss avatar Dec 11 '17 21:12 brandonweiss

Hmm - this still does not seem to be working for me. I have the following setting:

hyperStatusLine: {
  dirtyColor: 'salmon',
  aheadColor: 'greenyellow'
},

and

plugins: [
  'hyper-chesterish',    
  'hypercwd',
  'hyper-statusline'
],

The dirtyColor and aheadColor does not seem to have any effect. Regardless of the state of my repo, I always get the same view:

hyper

Or I misunderstood the meaning of dirtyColor and aheadColor? Is it that dirtyColor means that the branch name will get this color when the repo has uncommitted changes? And what is then aheadColor?

Thanks in advance for any clarifications.

marcinczenko avatar Jan 26 '18 15:01 marcinczenko