react-native-date-picker icon indicating copy to clipboard operation
react-native-date-picker copied to clipboard

Title, Confirm and Cancel in Dark mode is not visible

Open theDevSoham opened this issue 1 year ago • 9 comments

Describe the bug Only tested on android: The dark mode text for the calendar is not changing color with theme change.

Expected behavior To be set to white when in dark mode or preferably should take a customizalbe React.Fragment instead of a string

To Reproduce Add example code that reproduces the behavior.

export default class App extends Component {

  state = { date: new Date() }

  render = () =>
    <DatePicker
                modal
                open={true}
                date={state }
                onConfirm={(d) => {
                  console.log("Date changed: ", d)
                }}
                onCancel={() => {
                  console.log("Cancelled: ")
                }}
                theme="dark"
                title="Select Date"
              />

}

Smartphone (please complete the following information):

  • OS: [Android]

  • React Native version [e.g. 0.67.3]

  • react-native-date-picker version [e.g. 4.3.3]

  • For Light mode:

image

  • For Dark mode:

image

theDevSoham avatar Oct 31 '23 07:10 theDevSoham

@henninghall please check

theDevSoham avatar Oct 31 '23 07:10 theDevSoham

Same issue here

brandon-austin-lark avatar Nov 08 '23 19:11 brandon-austin-lark

Same issue but only on google device. I have tested on a samsung s10e and problem will not appear

cyrilmarceau avatar Nov 17 '23 13:11 cyrilmarceau

We've had to work around this by using theme="light" but it would be great to get this fixed.

pranjal-easy-peasy avatar Nov 29 '23 12:11 pranjal-easy-peasy

theme="light" actually works fine...there's only some issue with dark mode heading and bottom buttons. It really needs some fix.

theDevSoham avatar Nov 30 '23 04:11 theDevSoham

This same issue exists for me with the date picker fields. This can be seen in #734

z1haze avatar Dec 08 '23 01:12 z1haze

Is there a planned fix or we might as well fork this repo and do it ourselves?

mkhoussid avatar Apr 18 '24 15:04 mkhoussid

PRs are welcome!

henninghall avatar Apr 18 '24 16:04 henninghall

cancelText does it work for iOS as well?

vinamrahalgar avatar Jun 26 '24 10:06 vinamrahalgar