react-native-date-picker
react-native-date-picker copied to clipboard
Title, Confirm and Cancel in Dark mode is not visible
Describe the bug Only tested on android: The dark mode text for the calendar is not changing color with theme change.
Expected behavior To be set to white when in dark mode or preferably should take a customizalbe React.Fragment instead of a string
To Reproduce Add example code that reproduces the behavior.
export default class App extends Component {
state = { date: new Date() }
render = () =>
<DatePicker
modal
open={true}
date={state }
onConfirm={(d) => {
console.log("Date changed: ", d)
}}
onCancel={() => {
console.log("Cancelled: ")
}}
theme="dark"
title="Select Date"
/>
}
Smartphone (please complete the following information):
-
OS: [Android]
-
React Native version [e.g. 0.67.3]
-
react-native-date-picker version [e.g. 4.3.3]
-
For Light mode:
- For Dark mode:
@henninghall please check
Same issue here
Same issue but only on google device. I have tested on a samsung s10e and problem will not appear
We've had to work around this by using theme="light"
but it would be great to get this fixed.
theme="light"
actually works fine...there's only some issue with dark mode heading and bottom buttons. It really needs some fix.
This same issue exists for me with the date picker fields. This can be seen in #734
Is there a planned fix or we might as well fork this repo and do it ourselves?
PRs are welcome!
cancelText does it work for iOS as well?