Henning Gerhardt

Using `RandomStringUtil.random` with a secure random device needs a more complicated method call which must be replicated on all places. That is the reason why a wrapper method is needed....

> Do we really need a cryptographically strong random number generator in class `UserGenerator`? As far as I see that class is only useful for tests, so I think the...

Okay, then I will close this pull request as the change is not needed or not wanted.

Displaying and using this properties are not the same. We (SLUB) are displaying them as this is done by Kitodo.Production but we are not using them (like in scripts calls...

I'm unsure if your suggested change create an issue for other (newer) ElasticSearch versions and how did this effect running Kitodo.Production instances which did not got the changes of the...

> > This development aims to replace the native ElasticSearch integration with the Hibernate Search framework, which uses ElasticSearch. Little shall change for those starting the application out. > >...

Is updating ElasticSearch to 7.17.x an option as 7.3.x is very old? Even the used Java version is to new as only Java 11 is currently supported (but should not...

Maybe this "change" is coming from updating the ElasticSearch client libraries between Kitodo.Production release 3.5.x to 3.6.x (7.17.7 over 7.17.8 to 7.17.10). If the Kitodo.Production version was 3.4.x or earlier...

I can understand your suggestion but I don't know if this change is more readable then before. I feel the lost of which explicit class of a package is used....

I don't think that is a good idea to access the Hibernate data directly in the UI - from a security view. There was many exploits in the used UI...