Henning Gerhardt

Results 91 comments of Henning Gerhardt

If I'm working on this this pull request would not visible or on draft mode. I'm only refreshing all my pull request after changes on the main / master branch...

Thanks for hinting this out @thomaslow ! I will try to adjust this PR als dublicated / similar jar files are bad (jaxb-api) and if a dependency is already provided...

@thomaslow : I updated my PR according to your suggestions. If one or both additional commits are not wanted I would remove them.

Updating `org.jvnet.jaxb` to version `2.0.9` including the replacement to use the commons-lang for generating the `equals` and ` hash` methods will reduce the error counting in CodeQL for this generated...

> Thanks a lot for the explanation @thomaslow I understand that both approaches have their advantages (streamlining pom files vs. explicit dependencies for directly used packages and classes) and would...

> > @solth : Did I understand you correct, that I should revert my commit [f46777d](https://github.com/kitodo/kitodo-production/commit/f46777d80d9ce4eadc919d1ef338f726832a44cb) in total? If so then your commenting is obsolete or? > > @henning-gerhardt yes,...

It looks like that in previous commits the execute right change was unintended added to the repository. The test itself is right and tests / test suites should set and...

@BartChris > we should display multiple results in the search in the Title Record Link tab since there is no real reason why that worked in Kitodo 3.6 but does...

> This is introduced by the current pull request. In master you get multiple hits. Then this must be fixed in current pull request.

@BartChris : maybe by opening two issues with references to this issue? Both issues can be solved independent of each other (or maybe even together) so maybe one of the...