pipez icon indicating copy to clipboard operation
pipez copied to clipboard

Chunk loading config option

Open jeremiahwinsley opened this issue 2 years ago • 3 comments

Bug description When connected to pipes in unloaded chunks, (likely after some load/unload cycles) the fluid pipe loads chunks.

This was a universal pipe with an infinity upgrade.

See attached screenshot/link to Spark profile.

https://spark.lucko.me/0QHI3cu8zB

2022-04-01 10_56_00-Profile at 10_35AM 4_1_2022

From a quick look, it seems this could be fixed by checking whether the position is loaded first here:

https://github.com/henkelmax/pipez/blob/f91fd2e063108fff3e857281b93f34aaec5ef96d/src/main/java/de/maxhenkel/pipez/blocks/tileentity/types/FluidPipeType.java#L205

The same issue is potentially present on other pipe types as well.

Versions

  • Minecraft version: 1.16.5
  • Forge version: 36.2.31
  • Mod version: 1.2.15

Other Mods Modpack ATM6 1.8.22

jeremiahwinsley avatar Apr 01 '22 15:04 jeremiahwinsley

It is completely intended that the end of a pipez line loads chunks.

henkelmax avatar Apr 01 '22 15:04 henkelmax

If loading chunks is the desired behavior, then the bug is that it does not keep them loaded, instead constantly loading and unloading them. As you can see from the spark profile, this results in performance issues.

That said, I would like to have configuration options for this behavior if possible. We have other mods that provide chunk loading and would like to limit the amount of loaded chunks.

jeremiahwinsley avatar Apr 01 '22 16:04 jeremiahwinsley

Yeah, a config option might be appropriate.

henkelmax avatar Apr 01 '22 16:04 henkelmax