Chrome-proxy-helper icon indicating copy to clipboard operation
Chrome-proxy-helper copied to clipboard

why was Blacklist support removed?

Open pepijnmm opened this issue 1 year ago • 5 comments

I saw that in commit https://github.com/henices/Chrome-proxy-helper/commit/ccf3a2f712a6ebac4c866b59fbc8e5281a111b0c Blacklist started to be removed as an option. and with some commits after that, it got fully hidden as an option with only whitelist remaining. But I can't find any issue/pr on the reason why. I wanted to use this extension to only enable the proxy on certain websites. So this option would be usefull for me.
Is there a technical reason to not use it?

pepijnmm avatar May 24 '23 22:05 pepijnmm

Any update ?

Bonjour123 avatar Jul 08 '23 23:07 Bonjour123

@Bonjour123 As far as I could tell it's because chrome.proxy is now used and that only has a bypass list option. https://developer.chrome.com/docs/extensions/reference/proxy/ Bypass list: "Individual servers may be excluded from being proxied with the bypassList" It's not regex sadly.

pepijnmm avatar Jul 09 '23 18:07 pepijnmm

@Bonjour123 As far as I could tell it's because chrome.proxy is now used and that only has a bypass list option. https://developer.chrome.com/docs/extensions/reference/proxy/ Bypass list: "Individual servers may be excluded from being proxied with the bypassList" It's not regex sadly.

pac script can set proxy only for some domains. https://developer.mozilla.org/en-US/docs/Web/HTTP/Proxy_servers_and_tunneling/Proxy_Auto-Configuration_PAC_file

henices avatar Jul 14 '23 15:07 henices

I saw that in commit ccf3a2f Blacklist started to be removed as an option. and with some commits after that, it got fully hidden as an option with only whitelist remaining. But I can't find any issue/pr on the reason why. I wanted to use this extension to only enable the proxy on certain websites. So this option would be usefull for me. Is there a technical reason to not use it?

The blacklist UI is a mistake. I did not write any code for the blacklist feature. Ten years ago, all Chrome proxy extensions had bugs, so I wrote my own. I may add Manifest V3 support for this extension in the future.

henices avatar Jul 14 '23 15:07 henices

Thx henices, I will take a look if I have time soon to see if I I can generate the pac file on the fly to generate the blacklist. Seems to be possible: https://stackoverflow.com/questions/9022322/using-a-local-proxy-auto-configuration-pac-file-for-proxy-settings-from-a-chr

@henices I already have manifest 3 running on my fork. But I changed how it starts a proxy by moving more stuff to the background js so it won't be a copy paste. Also added a feature that I needed so that I won't be able to access some sites without the proxy on.

pepijnmm avatar Jul 14 '23 23:07 pepijnmm