ColorPicker icon indicating copy to clipboard operation
ColorPicker copied to clipboard

Published 20 hours ago • verified publisher icon hendriku

`saturation` and `brightness`

Open L1cardo opened this issue 4 years ago • 7 comments

Can you add saturation and brightness ? I have read the issue #8, but I think it will be great if you add this support.

L1cardo avatar Oct 19 '20 14:10 L1cardo

I see the need of using saturation and brightness options in real life. Currently I am unsure about how to implement them. @L1cardo would you expect them being used within two sliders (as https://github.com/benjiburgess/ColorPicker does) or in a different input form? Thrilled to hear your ideas.

hendriku avatar Oct 19 '20 16:10 hendriku

image image image would be some known alternative patterns

hendriku avatar Oct 19 '20 16:10 hendriku

@hendriku Two sliders as https://github.com/benjiburgess/ColorPicker will do.

  1. make the picker a circle instead of a ring
  2. two sliders below the picker

L1cardo avatar Oct 20 '20 12:10 L1cardo

Alright so the vision is clear ;) Will only get into start working on this from december. If anyone creates a PR earlier I'd be happy to merge

hendriku avatar Oct 26 '20 14:10 hendriku

👍 Vote on Third one

ryh avatar Nov 23 '20 05:11 ryh

Sorry to ask，but are you working on this？

L1cardo avatar Feb 20 '21 02:02 L1cardo

@L1cardo nothing to be sry about! Unfortunately I did not manage to invest time in this :'( Any PR adopting the solution from benjiburgess/ColorPicker will be happily reviewed and merged. As his fork and my package share the same license it would also be no problem to create a merge from his fork to my original package.

hendriku avatar Feb 22 '21 14:02 hendriku