ColorPicker icon indicating copy to clipboard operation
ColorPicker copied to clipboard

Workaround needed when building a release version

Open richardgroves opened this issue 4 years ago • 3 comments

Due to this issue https://github.com/yannickl/DynamicColor/issues/59 in DynamicColor repo this project also wont build in a release configuration.

The reporter of that issue has forked DynamicColor at https://github.com/t0rst/DynamicColor with a workaround.

I'm going to try and fork this repo and point the DynamicColor at that workaround for now.

richardgroves avatar May 12 '20 16:05 richardgroves

For anyone else coming across this issue my fork at https://github.com/NoodlFroot/ColorPicker has a fix - it uses a fork of DynamicColor at https://github.com/NoodlFroot/DynamicColor which has had the iOS deployment target upped to 11.0 which fixes the issue.

Once I've confirmed all is well I'll make some pull requests, but the original DynamicColor repo doesn't look very active.

richardgroves avatar May 13 '20 11:05 richardgroves

Hi richardgroves 🙌thanks for taking note of this issue! Feel free to create a PR for this anytime, I'd be very grateful

hendriku avatar May 13 '20 16:05 hendriku

I've made a Pull request to DynamicColor - https://github.com/yannickl/DynamicColor/pull/62 - we'll see if it is accepted. Otherwise I can do one for here that moves the dependency to my fork (or you can make your own fork @hendriku and keep it all together).

richardgroves avatar May 13 '20 16:05 richardgroves