hemelb icon indicating copy to clipboard operation
hemelb copied to clipboard

Nbc rebase

Open mdavezac opened this issue 10 years ago • 22 comments

see #591

mdavezac avatar Nov 05 '15 17:11 mdavezac

This is just to see if I can use anything for the RBC branch

mdavezac avatar Nov 05 '15 17:11 mdavezac

retest this please

rupertnash avatar Nov 16 '15 10:11 rupertnash

Should we merge this then?

mdavezac avatar Nov 25 '15 09:11 mdavezac

No, because I need to implement the switch from wait to test outlined in #590. The version as-is hurts single core and scaling performance.

rupertnash avatar Nov 25 '15 09:11 rupertnash

retest this please

rupertnash avatar Apr 05 '16 13:04 rupertnash

Note that Jenkins will need updated. Until this branch is merged, I've just edited the config in the GUI which will get overwritten somehow from the test_jobs branch. Need to remove the -i option from the command line and remove the ImageComparison test line. Should also removing the HEMELB_USE_STREAKLINES configure define.

rupertnash avatar Apr 05 '16 13:04 rupertnash

So this passes now! I discovered the odd performance was specific to my OpenMPI install and has vanished since I rebuilt it. Once I've tested it on ARCHER, we can merge.

rupertnash avatar Apr 05 '16 14:04 rupertnash

retest please

rupertnash avatar Apr 14 '16 08:04 rupertnash

test this please

rupertnash avatar Apr 21 '16 15:04 rupertnash

retest this please

mobernabeu avatar Aug 04 '16 12:08 mobernabeu

@jenshnielsen I cannot get this PR to retest in Jenkins. Is the "retest this please" hook still working?

mobernabeu avatar Aug 04 '16 12:08 mobernabeu

Could you give me admin rights to the HemeLB organisation. @jamespjh changed the url to the Jenkins service so we probably need to change the webhook endpoint

jenshnielsen avatar Aug 04 '16 12:08 jenshnielsen

@jenshnielsen I just made you Owner of UCL-CCS (that's the organisation behind the hemelb-dev/ repo). Am I getting this right?

mobernabeu avatar Aug 04 '16 13:08 mobernabeu

Yes I will have a look and you can remove me again when it works

jenshnielsen avatar Aug 04 '16 13:08 jenshnielsen

retest this please, innit

mobernabeu avatar Aug 04 '16 13:08 mobernabeu

This PR will close #647

rupertnash avatar Feb 21 '17 13:02 rupertnash

@mdavezac I'd appreciate it if you could have a glance at the problem with MPI+cmake on Legion+GNU. It is certainly possible there's an issue in the mpi.cmake file that checks there is MPI 3.0 available. I'm just going to check this on ARCHER

rupertnash avatar Feb 22 '17 12:02 rupertnash

For some reason this was stalled in Jenkins on the simulation shut down. Works fine on my MacBook, so retest this please to find out if this is just a one off.

rupertnash avatar Feb 23 '17 11:02 rupertnash

Pleased to say that unit and regression tests are passing on ARCHER. Gonna test scaling now.

rupertnash avatar Feb 28 '17 12:02 rupertnash

retest this please

rupertnash avatar Mar 08 '17 12:03 rupertnash

@rupertnash, the hand-rolled MPI version thingie breaks on legion with openmpi 1.8.4 (and gcc). It corresponds to version 3.0. Are you sure you need to roll out your own FindMPI + extra script?

mdavezac avatar Mar 31 '17 16:03 mdavezac

I'm not too keen on investigating why hand-rolled stuff breaks :( Unless it's my own hand-rolled crap :)

mdavezac avatar Mar 31 '17 16:03 mdavezac