Rails 5

[connorshea]

I wanted to suggest upgrading Helpy to Rails 5, or at least get a conversation started about it.

I've been keeping track of our progress getting to the upgrade at GitLab, figured you may find all my notes useful :)

Some notes based on a quick look through your Gemfile:

• Devise needs to be upgraded to 4.0+
• quiet_assets can be replaced by a sprockets-rails config option now (wait until Rails 4.2.7 for that, though)
• Rspec will need to be updated to 3.5.0
• acts-as-taggable-on is a blocker at the moment
• kaminari should be updated to 0.17.0
• route_translator needs to be upgraded to 5.0.0
• sass-rails needs 5.0.5
• globalize needs a new version released

Lots of information on upgrading those gems, etc. is available in the issue I linked above. This project looks awesome, kudos!

Best, Connor

[scott]

Thanks Connor, your tracking of this is really appreciated. I have been tracking Globalize since thats a really big blocker for us to go to Rails 5. I plan to start an official branch where we can start to work out the upgrade.

[connorshea]

:+1: to my knowledge we're the largest open source Rails app and have somehow managed to not fall behind on Rails releases, so I figured it'd be useful to track the progress in-depth for everyone else to learn from :)

Feel free to ping me if you run into any problems, I might be able to help - or at least know to look out for the problem in GitLab!

[olliebennett]

Great - thanks for kicking this off, @connorshea.

@scott it may be worth setting up a GitHub milestone for this. Until then, I'll track the related PRs here:

PR #230 - Update 'rails' and dependencies to 4.2.7 PR #231 - Replace 'quiet_assets' gem with config PR #232 - Remove RSpec Issue #233 - Update acts-as-taggable gem for Rails 5 PR #234 - Update 'kaminari' gem PR #235 - Update sass-rails gem PR #236 - Update 'devise' gem Issue #237 - Update 'globalize' gem for Rails 5

Note: some PRs may need rebasing for conflicts in Gemfile so will do so as we go.

Once the PRs are merged in, I'll create a Rails 5 PR (with Gemfile temporarily pointing to git repo for unreleased gems) to see what else breaks! :)

[scott]

As you can see, I set up a milestone. I will start to tick off these PRs as time allows. Most hopefully most will go in fairly easily.

[connorshea]

@scott @olliebennett with Devise you can update to 4.0 for now, which has Rails 5 support and just a deprecation warning for the omniauth change.

See https://github.com/plataformatec/devise/pull/3985

[connorshea]

You'll also need to upgrade the Gemfile to use at least Ruby 2.2.2 (right now it's 2.2.1), I'd recommend the latest patch release in the 2.2 series.

[scott]

Thanks @connorshea

[connorshea]

Also worth looking at rails5-spec-converter gem, because this change may cause a lot of deprecation warnings otherwise.

[connorshea]

Also with regards to Devise, here's how we fixed the deprecation warnings: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5331

[connorshea]

After a bit of sleuthing it also looks like you'll need to upgrade devise_invitable for Devise 4.1/4.2 support, though 4.0 is fine on the current version: https://github.com/scambra/devise_invitable/blob/master/CHANGELOG

[rip747]

I'm trying to do this now and route_translator is giving me heartburn... Seems that the "locales#redirect_on_locale" route doesn't set the locale in the route and it loop infinitely.

You can clone my repo and test it out if you want since I have a devcontainer working for it.

[rip747]

FYI... My main goal is to get helpy updated to Rails 8.0.