heat
heat copied to clipboard
Bug/992 precision loss
Description
Fixed precision loss in several functions when using float64
data type.
Issue/s resolved: #992
Changes proposed:
- Passed in the
dtype
argument to backend torch functions instead of converting to desired data type after using default torch data type.
Type of change
- Bug fix (non-breaking change which fixes an issue)
Due Diligence
- [ ] All split configurations tested
- [ ] Multiple dtypes tested in relevant functions
- [ ] Documentation updated (if needed)
- [ ] Updated changelog.md under the title "Pending Additions"
Does this change modify the behaviour of other functions? If so, which?
no
skip ci
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3302a44
) 91.83% compared to head (c815a29
) 91.81%.
:exclamation: Current head c815a29 differs from pull request most recent head e978b57. Consider uploading reports for the commit e978b57 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #993 +/- ##
==========================================
- Coverage 91.83% 91.81% -0.03%
==========================================
Files 77 72 -5
Lines 11193 10528 -665
==========================================
- Hits 10279 9666 -613
+ Misses 914 862 -52
Flag | Coverage Δ | |
---|---|---|
unit | 91.81% <100.00%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.