heat icon indicating copy to clipboard operation
heat copied to clipboard

Add `copy` kwarg to `asarray`

Open neosunhan opened this issue 2 years ago • 3 comments

Description

Enables copy kwarg in asarray. The keyword defaults to False for backward compatibility.

Issue/s resolved: #990

Type of change

  • New feature (non-breaking change which adds functionality)

Due Diligence

  • [ ] All split configurations tested
  • [ ] Multiple dtypes tested in relevant functions
  • [ ] Documentation updated (if needed)
  • [ ] Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

skip ci

neosunhan avatar Jul 15 '22 05:07 neosunhan

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Jul 15 '22 05:07 ghost

Codecov Report

Merging #991 (51ca6ec) into release/1.2.x (4368ee4) will increase coverage by 0.00%. The diff coverage is 92.59%.

@@              Coverage Diff               @@
##           release/1.2.x     #991   +/-   ##
==============================================
  Coverage          91.80%   91.80%           
==============================================
  Files                 65       65           
  Lines              10075    10152   +77     
==============================================
+ Hits                9249     9320   +71     
- Misses               826      832    +6     
Flag Coverage Δ
unit 91.80% <92.59%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
heat/core/manipulations.py 98.63% <ø> (ø)
heat/core/tests/test_suites/basic_test.py 98.07% <ø> (ø)
heat/nn/data_parallel.py 84.13% <ø> (ø)
heat/regression/lasso.py 92.42% <ø> (ø)
heat/core/factories.py 98.05% <86.95%> (-1.95%) :arrow_down:
heat/core/dndarray.py 96.92% <100.00%> (+0.12%) :arrow_up:
heat/core/random.py 99.67% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 15 '22 05:07 codecov[bot]

@JuanPedroGHM have we got a fitting label for these changes re: auto-generated changelog? I was going to suggest array-API. Also, I'm thinking we need some kind of roadblock for when we're about to merge a PR that hasn't been labelled properly.

ClaudiaComito avatar Aug 29 '22 03:08 ClaudiaComito

Switched base branch from main to release/1.2.x so we can release this sooner.

ClaudiaComito avatar Mar 06 '23 05:03 ClaudiaComito

Closing this as it is addressed in #1119

ClaudiaComito avatar Jun 13 '23 12:06 ClaudiaComito