heat icon indicating copy to clipboard operation
heat copied to clipboard

Features/384 sparse matrices

Open AmirTouilPU opened this issue 2 years ago • 2 comments

Description

New class: coo_matrix:

coo_matrix class (should be re-named to coo_array). Indices are calculated using a function in the class file

Issue/s resolved:

  • coo_indices are now working
  • gshape calculation from a torch.sparse_coo_tensor in the test.py file: turnt the shape to tuple (couldn't modify the tuple), then to a list, changed the gshape[split] value, then turnt it to a tuple again.

Does this change modify the behaviour of other functions? If so, which?

Should the function indices be part of the class?

AmirTouilPU avatar Jul 11 '22 23:07 AmirTouilPU

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Jul 11 '22 23:07 ghost

Following

ClaudiaComito avatar Jul 15 '22 09:07 ClaudiaComito

closing this as it is unfinished. Happy to reopen if somebody else wants to work on it.

ClaudiaComito avatar Aug 21 '23 08:08 ClaudiaComito