heat
heat copied to clipboard
Features/384 sparse matrices
Description
New class: coo_matrix:
coo_matrix class (should be re-named to coo_array). Indices are calculated using a function in the class file
Issue/s resolved:
- coo_indices are now working
- gshape calculation from a torch.sparse_coo_tensor in the test.py file: turnt the shape to tuple (couldn't modify the tuple), then to a list, changed the gshape[split] value, then turnt it to a tuple again.
Does this change modify the behaviour of other functions? If so, which?
Should the function indices be part of the class?
👇 Click on the image for a new way to code review
-
Make big changes easier — review code in small groups of related files
-
Know where to start — see the whole change at a glance
-
Take a code tour — explore the change with an interactive tour
-
Make comments and review — all fully sync’ed with github
Legend
Following
closing this as it is unfinished. Happy to reopen if somebody else wants to work on it.