heat icon indicating copy to clipboard operation
heat copied to clipboard

Fixes #814

Open marianna13 opened this issue 2 years ago • 2 comments

Description

Issue/s resolved: #814

Changes proposed:

  • Apply NumPy squeeze function to data that we read in load_csv function. It makes sure we don't get unnecessary dimensions to an array. E,g. array with shape (2,) will be loaded as an array with shape (2,1). This minor fix will make sure that shapes of arrays loaded with NumPy's loadtxt function will have equal shapes as arrays loaded with load_csv.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Due Diligence

  • [ x] All split configurations tested
  • [ x] Multiple dtypes tested in relevant functions
  • [ ] Documentation updated (if needed)
  • [ ] Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

no

marianna13 avatar Apr 09 '22 14:04 marianna13

GPU cluster tests are currently disabled on this Pull Request.

mtar avatar Apr 09 '22 14:04 mtar

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Apr 09 '22 14:04 ghost

Thank you for the PR!

github-actions[bot] avatar Aug 22 '23 12:08 github-actions[bot]

closing this as no distributed test cases

ClaudiaComito avatar Sep 04 '23 04:09 ClaudiaComito