heat icon indicating copy to clipboard operation
heat copied to clipboard

Published 20 hours ago • verified publisher icon helmholtz-analytics

fix #351: Solution 1: enforce weights.shape = x.shape for tuple axis

Open Mystic-Slice opened this issue 2 years ago • 3 comments

Issue/s resolved: #351

Type of change

Documentation update

Due Diligence

  • [ ] All split configurations tested
  • [ ] Multiple dtypes tested in relevant functions
  • [ ] Documentation updated (if needed)
  • [ ] Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes / no

skip ci

Mystic-Slice avatar Apr 03 '22 06:04 Mystic-Slice

GPU cluster tests are currently disabled on this Pull Request.

mtar avatar Apr 03 '22 06:04 mtar

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

ghost avatar Apr 03 '22 06:04 ghost

Hey @ClaudiaComito! Sorry for the late reply! I think the changes that you requested are already present in the code. See lines 286 - 299

Mystic-Slice avatar Apr 30 '22 01:04 Mystic-Slice

Changes moved to a new branch. See, https://github.com/helmholtz-analytics/heat/pull/1037

Mystic-Slice avatar Oct 22 '22 00:10 Mystic-Slice