heat icon indicating copy to clipboard operation
heat copied to clipboard

Published 20 hours ago • verified publisher icon helmholtz-analytics

setitem does not account for key changing the split axis

Open ben-bou opened this issue 3 years ago • 3 comments

Description Setitem checks self.split which is not correct because key may change the split axis if it is an int and smaller than split Correct behaviour would be to check self[key].split

e.g.: Line 1399 Line 1561

Version Info master

Additional comments Any other comments here.

ben-bou avatar Feb 08 '22 16:02 ben-bou

Addressed in #938

Reviewed within #1109

ClaudiaComito avatar Aug 21 '23 09:08 ClaudiaComito

Branch 917-setitem_does_not_account_for_key_changing_the_split_axis created!

github-actions[bot] avatar Oct 09 '23 09:10 github-actions[bot]