heat icon indicating copy to clipboard operation
heat copied to clipboard

Implement DNDarray.view()

Open ClaudiaComito opened this issue 4 years ago • 1 comments

[...] generally however I would obviously like to have something like a ht.view of the data, especially silent return of it. I am not 100% sure whether we can actually achieve this easily, due to the additional properties that we carry around and would have to watch out for. Yet, if somebody would successfully implement this, that would be a solid success for squeezing out further performance

Originally posted by @Markus-Goetz in https://github.com/helmholtz-analytics/heat/pull/677#issuecomment-717126805

ClaudiaComito avatar Oct 27 '20 10:10 ClaudiaComito

Also mentioned here #686

ClaudiaComito avatar Oct 27 '20 10:10 ClaudiaComito

As of Aug 2023, we're already using torch views internally whenever possible (although we might still have some unnecessary copies in legacy code, they usually get addressed during refactoring).

So I'm not sure this issue still needs to be addressed. I'll close it for now, let me know if you think it should be reopened.

ClaudiaComito avatar Aug 21 '23 09:08 ClaudiaComito