heat
heat copied to clipboard
added jitting to torch skew and kurtosis
Description
jitting for skew and kurtosis. possibly more changes to come here, this is the branch to be used during benchmarking and testing of the moment functions
Changes proposed:
- jit the torch skew and torch kurtosis functions
Type of change
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
Due Diligence
- [x] All split configurations tested
- [x] Multiple dtypes tested in relevant functions
- [x] Documentation updated (if needed)
- [ ] Updated changelog.md under the title "Pending Additions"
Does this change modify the behaviour of other functions? If so, which?
no
Codecov Report
Merging #642 (acdecf4) into main (bc99e60) will decrease coverage by
87.69%
. The diff coverage is6.96%
.
@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 97.47% 9.78% -87.70%
==========================================
Files 87 87
Lines 17182 17386 +204
==========================================
- Hits 16748 1701 -15047
- Misses 434 15685 +15251
Flag | Coverage Δ | |
---|---|---|
gpu | 9.78% <6.96%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
heat/core/tests/test_statistics.py | 2.35% <0.00%> (-97.65%) |
:arrow_down: |
heat/core/statistics.py | 6.40% <6.30%> (-90.62%) |
:arrow_down: |
heat/core/dndarray.py | 24.80% <66.66%> (-71.95%) |
:arrow_down: |
heat/core/linalg/tests/test_basics.py | 1.75% <0.00%> (-98.25%) |
:arrow_down: |
heat/core/tests/test_manipulations.py | 2.01% <0.00%> (-97.92%) |
:arrow_down: |
heat/core/tests/test_factories.py | 2.73% <0.00%> (-97.27%) |
:arrow_down: |
heat/core/linalg/qr.py | 2.84% <0.00%> (-96.45%) |
:arrow_down: |
heat/core/tests/test_tiling.py | 3.83% <0.00%> (-96.17%) |
:arrow_down: |
heat/core/tests/test_random.py | 3.85% <0.00%> (-96.15%) |
:arrow_down: |
heat/core/tests/test_dndarray.py | 4.11% <0.00%> (-95.89%) |
:arrow_down: |
... and 69 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bc99e60...acdecf4. Read the comment docs.
about 54 lines are expected misses due to jitting + extreme corner cases that are beyond the scope of unit tests (implemented for SF and TS matrices on a larger test system). the code controlling this case is tested in the mean
unit tests as it is the case which requires the least overhead
with these lines added the patch coverage would increase to about 95%.
ive picked this back up, but im not sure about how long this will take. this branch was very very stale.
...it was still tested on travis...
Closing this as it is very outdated. Happy to reopen if @coquelin77 wants to refresh it. Thanks for all the work!