heat
heat copied to clipboard
Replace scattered scikit-learn references with central BSD-3 clause reference
Feature functionality Remove the scattered references to scikit learn (in the docstrings) and replace it with a BSD-3 clause reference.
Was this closed by #757 ?
I am not 100% sure, but it is likely. i think this can be closed for now under this assumption.
If we see something in the docs then we can make something short to remove it
It was not done as part of the PR. It is still an open todo
@Markus-Goetz can you add a link? What is this supposed to look like?
It was not closed by #757. At the moment we state in individual algorithms that we have used/adapted/been inspired by code of other libraries. It would be generally good to acknowledge this and particularly we are requested to do so if the used libraries are for example licensed under BSD-2/3 (see here https://en.wikipedia.org/wiki/BSD_licenses).
I am not sure how to do this best. Perhaps a high-level acknowledgment file and/or a remark in the docs, other options of your choosing
Branch docs/530-Replace_scattered_scikit-learn_references_with_central_BSD-3_clause_reference created!
Reasonable.
Reviewed within #1109
just a comment we could think about: this may be combined with collecting other literature/references of interest at a central place instead of scattering them.
~~Here's what needs to be done (see PyTorch/third_party):~~
- [ ] ~~create a directory
third_party
in the root directory of Heat's repository~~ - [ ] ~~in
third_party
, create git submodules for each reference library (see https://git-scm.com/book/en/v2/Git-Tools-Submodules)~~
Misunderstanding, apologies