heat Add correlation (1D)

Add correlation (1D)

Open coquelin77 opened this issue 5 years ago • 7 comments

Jun 07 '19 05:06 coquelin77

I will add some context here. This function should be included in the heat.signal module being implemented in #595

Related features_ #30 #920

https://numpy.org/doc/stable/reference/generated/numpy.correlate.html

Corresponding PyTorch operation: torch.nn.functional.conv1d

Apr 01 '22 09:04 ClaudiaComito

Still open.

Reviewed within #1109

Jul 31 '23 16:07 ClaudiaComito

Sep 18 '23 07:09 github-actions[bot]

If I understand correctly, this function could just call ht.convolve if the flipping of the kernel is skipped.

Jul 03 '24 09:07 ClaudiaComito

yes

Jul 03 '24 10:07 krajsek

And to make things non-confusing, pyTorch convolutions are in fact correlations

Jul 03 '24 10:07 krajsek

And to make things non-confusing, pyTorch convolutions are in fact correlations

Exactly.

I see this is assigned to you @krajsek , do you have time for it?

Jul 03 '24 11:07 ClaudiaComito