heat
heat copied to clipboard
Features/1243 refactoring of communication separate mpi4py wrappers from dn darrays
This PR addresses #1243
Description: TBD ... see comments below
Current problem: everything fails due to circular imports
Thank you for the PR!
Thank you for the PR!
Done so far:
- a new module
communication_backends
has been introduced -
communication.py
fromheat/core
has been divided intocommunications.py
(containing the basisCommunication
-class) andmpi4py4torch.py
(containing theMPICommunication
-class and the wrappers formpi4py
-functionality fortorch
) - calling any MPI-communication with DNDarrays as buffers is deprecated; everywhere in the code such calls have been replaced by the equivalent way using the local arrays of a DNDarray as buffers instead (actually, such a check and reference of the local arrays has been done in all communication-functions previously)
To do:
- the tests for the no-more existing
heat/core/communication.py
are still inheat/core/tests/test_communication.py
(although being adapted according to the last bullet point above); however, it would be favourable to rewrite them as tests toheat/communication_backends/mpi4py4torch.py
, i.e. to remove any reference toDNDarrays
there in order to achieve a clear separation.
Codecov Report
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
6a5115c
) 91.81% compared to head (47a4d25
) 91.83%. Report is 1 commits behind head on main.
:exclamation: Current head 47a4d25 differs from pull request most recent head abe3d20. Consider uploading reports for the commit abe3d20 to get more accurate results
Files | Patch % | Lines |
---|---|---|
heat/core/linalg/solver.py | 50.00% | 4 Missing :warning: |
heat/communication_backends/communication.py | 96.36% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #1265 +/- ##
==========================================
+ Coverage 91.81% 91.83% +0.01%
==========================================
Files 79 79
Lines 11463 11171 -292
==========================================
- Hits 10525 10259 -266
+ Misses 938 912 -26
Flag | Coverage Δ | |
---|---|---|
unit | 91.83% <94.59%> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you for the PR!