heat
heat copied to clipboard
Refactor `ht.concatenate()`
Due Diligence
- General:
- [ ] base branch must be
main
for new features, latest release branch (e.g.release/1.3.x
) for bug fixes - [ ] title of the PR is suitable to appear in the Release Notes
- [ ] base branch must be
- Implementation:
- [ ] unit tests: all split configurations tested
- [ ] unit tests: multiple dtypes tested
- [ ] documentation updated where needed
Description
Issue/s resolved: #
Changes proposed:
Type of change
Memory requirements
Performance
Does this change modify the behaviour of other functions? If so, which?
yes / no
What I have done:
- resolved merge conflict with main in manipulations in favour of the new file
- added old concatenate-docstring and changed a lambda-function into a proper def-construction in order to let pre-commit run through
- removed test_collect from test_manipulations since collect has been removed from manipulations (I guess, because there is already a collect-function in dndarray?)
Now, it looks like that there are multiple errors for a single process (non-split arrays)
This pull request is stale because it has been open for 60 days with no activity.
This should not be closed, I just assigned myself for review