heat icon indicating copy to clipboard operation
heat copied to clipboard

Refactor `ht.concatenate()`

Open Shoham-M opened this issue 1 year ago • 5 comments

Due Diligence

  • General:
    • [ ] base branch must be main for new features, latest release branch (e.g. release/1.3.x) for bug fixes
    • [ ] title of the PR is suitable to appear in the Release Notes
  • Implementation:
    • [ ] unit tests: all split configurations tested
    • [ ] unit tests: multiple dtypes tested
    • [ ] documentation updated where needed

Description

Issue/s resolved: #

Changes proposed:

Type of change

Memory requirements

Performance

Does this change modify the behaviour of other functions? If so, which?

yes / no

Shoham-M avatar Aug 29 '23 10:08 Shoham-M

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Aug 29 '23 10:08 ghost

What I have done:

  • resolved merge conflict with main in manipulations in favour of the new file
  • added old concatenate-docstring and changed a lambda-function into a proper def-construction in order to let pre-commit run through
  • removed test_collect from test_manipulations since collect has been removed from manipulations (I guess, because there is already a collect-function in dndarray?)

mrfh92 avatar Oct 16 '23 12:10 mrfh92

Now, it looks like that there are multiple errors for a single process (non-split arrays)

mrfh92 avatar Oct 16 '23 12:10 mrfh92

This pull request is stale because it has been open for 60 days with no activity.

github-actions[bot] avatar Dec 18 '23 02:12 github-actions[bot]

This should not be closed, I just assigned myself for review

ClaudiaComito avatar Jan 22 '24 09:01 ClaudiaComito