heat
heat copied to clipboard
Indexing with 0-dimensional arrays
Description
- Fixes a bug where adding a dimension (via slicing with
None
) on an array with an axis of length 0 results in an error. - Fixes a bug where using a 0-dimensional array to index results in an error.
Issue/s resolved: #1012, #1019
Changes proposed:
Type of change
- Bug fix (non-breaking change which fixes an issue)
Due Diligence
- [ ] All split configurations tested
- [ ] Multiple dtypes tested in relevant functions
- [ ] Documentation updated (if needed)
- [ ] Updated changelog.md under the title "Pending Additions"
Does this change modify the behaviour of other functions? If so, which?
no
skip ci
👇 Click on the image for a new way to code review
-
Make big changes easier — review code in small groups of related files
-
Know where to start — see the whole change at a glance
-
Take a code tour — explore the change with an interactive tour
-
Make comments and review — all fully sync’ed with github
Legend
Thanks for this @neosunhan . These problems are being addressed in the general indexing overhaul #938 . I'm going to close this PR for now.