heat icon indicating copy to clipboard operation
heat copied to clipboard

Bug/1004 0-dimensional singleton arrays

Open neosunhan opened this issue 2 years ago • 1 comments

Description

Return 0-dimensional (instead of 1-dimensional) singleton arrays for several functions.

Issue/s resolved: #1004

Changes proposed:

  • Remove flattening step after partial reduction operation for 0-dimensional arrays

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Due Diligence

  • [ ] All split configurations tested
  • [ ] Multiple dtypes tested in relevant functions
  • [ ] Documentation updated (if needed)
  • [ ] Updated changelog.md under the title "Pending Additions"

Does this change modify the behaviour of other functions? If so, which?

yes

  • all
  • any
  • prod
  • sum
  • argmax
  • argmin
  • max
  • mean
  • min
  • std
  • var

skip ci

neosunhan avatar Aug 15 '22 07:08 neosunhan

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ghost avatar Aug 15 '22 07:08 ghost

Thank you for the PR!

github-actions[bot] avatar Aug 21 '23 03:08 github-actions[bot]

Codecov Report

Merging #1005 (6be8b4c) into main (7830d74) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1005      +/-   ##
==========================================
+ Coverage   92.16%   92.19%   +0.03%     
==========================================
  Files          75       75              
  Lines       10708    10699       -9     
==========================================
- Hits         9869     9864       -5     
+ Misses        839      835       -4     
Flag Coverage Δ
unit 92.19% <100.00%> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
heat/core/_operations.py 96.11% <100.00%> (+0.06%) :arrow_up:
heat/core/sanitation.py 98.38% <100.00%> (+1.32%) :arrow_up:
heat/core/tests/test_suites/basic_test.py 98.07% <100.00%> (ø)

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 21 '23 03:08 codecov[bot]

Thank you for the PR!

github-actions[bot] avatar Aug 21 '23 04:08 github-actions[bot]