heat
heat copied to clipboard
Bug/999 Fix `keepdim` in `any`/`all`
Description
keepdim=True
now works in any
/all
when axis=None
Issue/s resolved: #999
Changes proposed:
- If
axis=None
, setaxis
to a tuple of all dimensions. This is equivalent to performing a reduction over all dimensions.
Type of change
- Bug fix (non-breaking change which fixes an issue)
Due Diligence
- [ ] All split configurations tested
- [ ] Multiple dtypes tested in relevant functions
- [ ] Documentation updated (if needed)
- [ ] Updated changelog.md under the title "Pending Additions"
Does this change modify the behaviour of other functions? If so, which?
no
skip ci
👇 Click on the image for a new way to code review
-
Make big changes easier — review code in small groups of related files
-
Know where to start — see the whole change at a glance
-
Take a code tour — explore the change with an interactive tour
-
Make comments and review — all fully sync’ed with github
Legend
Codecov Report
Merging #1000 (3d8b207) into main (d5c14b7) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1000 +/- ##
=======================================
Coverage 91.67% 91.68%
=======================================
Files 65 65
Lines 9974 9978 +4
=======================================
+ Hits 9144 9148 +4
Misses 830 830
Flag | Coverage Δ | |
---|---|---|
unit | 91.68% <100.00%> (+<0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
heat/core/logical.py | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more