monocular icon indicating copy to clipboard operation
monocular copied to clipboard

Turn off .chart-details-usage

Open lemaral opened this issue 6 years ago • 3 comments

I would like to document the chart usage instructions only in the chart README, and so to not confuse users I would like to hide the chart details usage. Basically this: .chart-details-usage { display: none; is enough, so I wonder if it could be possible to add a configuration for this (instead of hard-coding). Thanks

lemaral avatar Feb 18 '19 21:02 lemaral

I think that could be useful, we can add a boolean option for this in https://github.com/helm/monocular/blob/master/frontend/src/assets/js/overrides.js#L6 for showChartUsage and use that in the ChartDetailsInfo component to hide https://github.com/helm/monocular/blob/master/frontend/src/app/chart-details/chart-details-info/chart-details-info.component.html#L3.

prydonius avatar Feb 19 '19 19:02 prydonius

Thanks! Following your guidance, I can do the PR if it's ok

lemaral avatar Feb 19 '19 20:02 lemaral

@lemaral that would be amazing!

prydonius avatar Feb 19 '19 22:02 prydonius