helm icon indicating copy to clipboard operation
helm copied to clipboard

Proposal: disable values schema validation for charts including a values.schema.json file

Open antaloala opened this issue 3 years ago • 8 comments

Even when a chart designer/maintainer has decided to include a values.schema.json file in the Helm chart he/she releases it could be that the user of that chart (using it directly or as a dependency in an integration/umbrella Helm chart) cannot assure to fulfill the defined schema for the deployment specific values passed to that subchart (e.g. he/she passes a deployment specific values.yaml file to the helm install/upgrade command applied on that chart, where some "old" Helm parameter removed from the values.schema.json of a newer version of that (sub)chart still remains).

I think it would be useful to support a new option in helm install, helm upgrade, helm lint and helm template allowing to disable the values schema validation (in case a values.schema.json file is packaged in the target Helm chart or some listed subchart)

antaloala avatar Nov 24 '21 13:11 antaloala

Running into this issue now. A helm chart im using has a values.schema.json which points to a git repo for some of the values, which unfortunately means I cant helm install the chart without an internet connection unless I untar the helm chart, remove the schema file, and then install. Would be interested in a flag like --skip-validation where it does the equivalent of not having the schema file in the chart. Does a flag like this exist?

the-scott-hand avatar Feb 16 '22 22:02 the-scott-hand

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

github-actions[bot] avatar May 18 '22 00:05 github-actions[bot]

(Just bumping so the stale bot doesn't close this feature request!)

jedcunningham avatar May 18 '22 02:05 jedcunningham

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

github-actions[bot] avatar Aug 17 '22 00:08 github-actions[bot]

(Not stale)

jedcunningham avatar Aug 17 '22 01:08 jedcunningham

Would love to see this implemented

Salec avatar Sep 09 '22 17:09 Salec

As a developer of charts with linked values schemas I would also want to not prevent my users from failing to install the script when not having internet connection. :+1: for this feature request.

lubojr avatar Oct 21 '22 13:10 lubojr

Hello, I made an attempt to solve this problem. This is my first time contributing so, please let me know if anything is wrong so I can fix.

JvD-Ericsson avatar Nov 04 '22 15:11 JvD-Ericsson

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

github-actions[bot] avatar Feb 07 '23 01:02 github-actions[bot]

Can we get a maintainer to review #11510 for integration? @joejulian ?

zswanson avatar Jun 20 '23 13:06 zswanson

Joe is on vacation - VacationBot

joejulian avatar Jun 20 '23 14:06 joejulian

is there any progress on this? In air-gapped evironments this can be crucial.

michbeck100 avatar Sep 06 '23 07:09 michbeck100

We've made an in-CI workaround by fetching the chart to our CI agent, inflating it, renaming the json schema file, and then running the helm upgrade with the local chart path rather than the remote. Its ugly and I hate it.

zswanson avatar Sep 06 '23 14:09 zswanson

I have created a merge request (https://github.com/helm/helm/pull/12743) that solves this issue, including tests and doc updates. However, it seems to be really hard to get hold of a maintainer to look into it. I have mentioned it on the #helm-dev slack channel, but no luck. I will try again, but maybe you can vote on the PR if you want to see this fixed.

anessi avatar Mar 25 '24 08:03 anessi

@anessi it looks like your PR got approved! I would love to have this merged in (bumped up against this myself earlier). Do you need any help rebasing or anything?

tthornton3-chwy avatar May 02 '24 10:05 tthornton3-chwy

@anessi it looks like your PR got approved! I would love to have this merged in (bumped up against this myself earlier). Do you need any help rebasing or anything?

@tthornton3-chwy : I'd love to merge, but I don't have write permissions, so depend on the maintainers to merge it. I will leave a comment on the merge request.

anessi avatar May 02 '24 10:05 anessi