helm-www icon indicating copy to clipboard operation
helm-www copied to clipboard

Add "next page" button to blog

Open karenhchu opened this issue 5 years ago • 7 comments

It's not obvious that the current arrow at the bottom of the blog page is to go to the next page of blogs (the UX with the "1" to the right of the arrow made me think there was only 1 page of blogs). Can we add some text to make it more obvious where people should click for older blog posts?

karenhchu avatar Aug 13 '20 06:08 karenhchu

Good catch

I would suggest "previous" be added as well when not on the first page. The arrow is small. Might also do something with the arrows that's easier to notice.

mattfarina avatar Aug 18 '20 13:08 mattfarina

@flynnduism I would like to work on this issue /assign

AakashRaj20 avatar Jun 10 '22 10:06 AakashRaj20

@AakashRaj20 by all means, thank you

flynnduism avatar Jun 10 '22 13:06 flynnduism

@AakashRaj20 by all means, thank you

Hey, I am new to open source I understood what to do but I am unable to locate the code file in which I have to do the changes. Can you point me in the right direction?

AakashRaj20 avatar Jun 15 '22 16:06 AakashRaj20

https://github.com/helm/helm-www/blob/7e90c449a757aad5480fba1d5a5c718ea12cac0a/themes/helm/layouts/blog/list.html#L34-L40

bacongobbler avatar Jun 15 '22 16:06 bacongobbler

https://github.com/helm/helm-www/blob/7e90c449a757aad5480fba1d5a5c718ea12cac0a/themes/helm/layouts/blog/list.html#L34-L40

Thank you I got it. Just one minor question do i replace the arrows with a next and previous text or do I make a button for next and previous?

AakashRaj20 avatar Jun 15 '22 16:06 AakashRaj20

@AakashRaj20 by all means, thank you

Hey I have raised a PR after making some changes. Please review it and tell me if any changes are required I will make it.Thanks for all the help @bacongobbler.

AakashRaj20 avatar Jun 15 '22 17:06 AakashRaj20

closing as per review in #1324.

bacongobbler avatar Nov 01 '22 14:11 bacongobbler