helm-mapkubeapis icon indicating copy to clipboard operation
helm-mapkubeapis copied to clipboard

fix(Map.yaml) : added new map for hpa apiversion autoscaling/v2beta2

Open ramdaspotale opened this issue 2 years ago • 7 comments

The current version of plugin does not update hpa release manifest when it contains apiVersion autoscaling/v2beta2, it only works for autoscaling/v2beta1. hence i added one more mapping

ramdaspotale avatar Sep 18 '23 12:09 ramdaspotale

pinging @mattfarina for approval

ramdaspotale avatar Sep 18 '23 13:09 ramdaspotale

@hickeyma

ramdaspotale avatar Sep 18 '23 13:09 ramdaspotale

sorry for pinging individually as this changes is pending since March...and are causing issues with plugin

ramdaspotale avatar Sep 18 '23 13:09 ramdaspotale

Sending my approval of this PR as a bump,

Posting in case anybody isn't aware, As a workaround, you can copy the Map.yaml in this repo (along with the added HPA mapping) and save it as a local file to reference when running the binary with the following flag.

--mapfile string           path to the API mapping file (default "config/Map.yaml")

It's such a simple change and would also really appreciate if this got merged sooner rather than later

skhtor avatar Oct 11 '23 23:10 skhtor

Thanks @soony88 for the bump, also for sharing the workaround although already i have build plugin with updated map file as workaround.

ramdaspotale avatar Oct 12 '23 08:10 ramdaspotale

Please merge asap. We really need this feature

multhamb avatar Feb 06 '24 10:02 multhamb

+1

manny-semc avatar Jun 05 '24 19:06 manny-semc

Thanks for the PR. Multiple PRs came in to address this and another one has already been merged. Closing this one.

mattfarina avatar Aug 09 '24 14:08 mattfarina