community icon indicating copy to clipboard operation
community copied to clipboard

hip introducing `export-values` for better composability

Open c0d1ngm0nk3y opened this issue 3 years ago • 9 comments

Composing Helm charts using dependencies is currently limited because it is not possible to create a chart with a defined set of values and distribute them to subcharts.

This hip proposes an export-values structure to address this issue.

c0d1ngm0nk3y avatar Feb 04 '22 14:02 c0d1ngm0nk3y

@hickeyma , @marckhouzam HI. Is there anything missing? It would be great to get some feedback for this HIP, but we cannot add reviewers. What is the preferred approach?

c0d1ngm0nk3y avatar Feb 15 '22 07:02 c0d1ngm0nk3y

Would really be great to get any reaction at all. Is the HIP still used at all?

c0d1ngm0nk3y avatar Feb 22 '22 07:02 c0d1ngm0nk3y

It's currently next to impossible to use the parent - subchart pattern with the helmfile values that jenkins-x passes to each release. This would unblock me in that scenario and also enable me to make a bunch of my other chart values way more DRY.

joshuasimon-taulia avatar Mar 10 '22 02:03 joshuasimon-taulia

Discussion in March 17, 2022 helm developer call: https://docs.google.com/document/d/1d-6xJEx0C78csIYSPKJzRPeWaHG_8W1Hjl72OJggwdc/edit?usp=sharing

bridgetkromhout avatar Mar 17 '22 16:03 bridgetkromhout

Looks like the next available number for a HIP is "0016". @c0d1ngm0nk3y you can replace the "9999" with "0016" in the file and in the name of the file.

marckhouzam avatar Mar 24 '22 17:03 marckhouzam

Looks like the next available number for a HIP is "0016". @c0d1ngm0nk3y you can replace the "9999" with "0016" in the file and in the name of the file.

Done

phil9909 avatar Mar 24 '22 17:03 phil9909

@jdolitsky anything missing to get this HIP merged?

loewenstein avatar Apr 10 '22 11:04 loewenstein

@jdolitsky anything missing to get this HIP merged?

HIPs need two approvals to get merged

phil9909 avatar Apr 28 '22 15:04 phil9909

With two approvals (from @scottrigby & @jdolitsky) and @mattfarina's comments supposedly addressed, could we maybe proceed and try to get this HIP merged soon and the implementation into 3.11.0?

3.11.0 is the next feature release and will be released on January 18, 2023

loewenstein avatar Oct 01 '22 07:10 loewenstein