chartmuseum icon indicating copy to clipboard operation
chartmuseum copied to clipboard

Add linting steps to CI (github actions)

Open cbuto opened this issue 2 years ago • 3 comments

We should introduce linting checks as a part of our CI process that are ran on both PRs and the main branch.

    • [x] Resolve linting failures that currently exist (either fix or add skips)
    • [ ] Add a linting step to github actions that runs on PRs and main. The official golangci-lint action will comment on PRs making it easier to surface issues, that might be the way to go.

The linting failures can be worked overtime as long as they are all resolved before linting is added to GitHub actions.

cbuto avatar Mar 24 '22 14:03 cbuto

Hey, @cbuto I would like to pick up this issue.

hydeenoble avatar May 06 '22 13:05 hydeenoble

Sure please, go ahead and pick it up. I was supposed to work on it but my hands are full right now. Let us follow if you have any follow up questions

nerdeveloper avatar May 06 '22 14:05 nerdeveloper

Awesome, Thanks @nerdeveloper. you can also assign the issue to me.

hydeenoble avatar May 06 '22 16:05 hydeenoble