chartmuseum icon indicating copy to clipboard operation
chartmuseum copied to clipboard

Summary metrics don't exist

Open jayme-github opened this issue 5 years ago • 4 comments

The summary metrics that are listed in the README.md do not exist:

  • chartmuseum_request_duration_seconds
  • chartmuseum_request_duration_seconds
  • chartmuseum_response_size_bytes

The corresponding total metrics (*_sum, *_count) do exist, though.

jayme-github avatar Jul 07 '20 10:07 jayme-github

I think it should be with EnableMetrics is on (with the --disablemetrics not set) , chartmuseum uses the prometheus's stdMetrics list , which describes the request_duration_seconds as the Summary type . And you can refer to your $MUSEUM_HOST/metrics to check if it is exist.

image

It is LGTM though.

scbizu avatar Jul 08 '20 19:07 scbizu

Yeah, sum and count are correctly exposed, but the actual quantiles are missing.

jayme-github avatar Jul 11 '20 17:07 jayme-github

hmm , I see .

It seems that go-gin-prometheus do not support quantile lables by default.

scbizu avatar Jul 12 '20 07:07 scbizu

cc @davidovich - I think you helped w these metrics?

jdolitsky avatar Jul 13 '20 14:07 jdolitsky