chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

use .helmignore when identifying changed charts

Open jouve opened this issue 2 years ago • 4 comments

What this PR does / why we need it:

use .helmignore when identifying changed charts.

The use of .helmignore is disabled by default (current behaviour) and enabled with --use-helmignore

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #530

Special notes for your reviewer:

pkg/ignore/rules.go is an exact copy of https://github.com/helm/helm/blob/main/internal/ignore/rules.go

the FilterFiles function is adapted from https://github.com/helm/helm/blob/main/pkg/chart/loader/directory.go#L46

jouve avatar Aug 31 '23 20:08 jouve

this can be tested here with

  • https://github.com/helm/chart-testing/pull/601
  • https://github.com/helm/chart-testing/pull/591
  • https://github.com/helm/chart-testing/pull/510
  • https://github.com/helm/chart-testing/pull/508

jouve avatar Oct 04 '23 08:10 jouve

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 19 '23 01:11 github-actions[bot]

Up

jouve avatar Nov 19 '23 09:11 jouve

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jan 05 '24 01:01 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Mar 06 '24 01:03 github-actions[bot]

up

jouve avatar Mar 06 '24 22:03 jouve

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Apr 21 '24 01:04 github-actions[bot]

please regen the docs and check in and it will pass

davidkarlsen avatar Apr 24 '24 21:04 davidkarlsen