chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

feat: evaluate .ignore files during the change detection process

Open philippwaller opened this issue 2 years ago • 1 comments

What this PR does / why we need it: This PR adds the possible to exclude files during the change detection process. This can be particularly useful in the context of the version increment check. If the feature is enabled, all .ctignore & .helmignore files inside the configured chart directories are evaluated by default and applied relative to the file path. All common glob patterns including the globstar pattern ** are supported. In addition, the config parameter considered-dotignore-files can be adjusted to specify which .ignore files are to be considered.

Added config parameters (default values):

evaluate-dotignore-files: false
considered-dotignore-files:
    - .ctignore
    - .helmignore

Special notes for your reviewer: I added/modified test cases to cover the new functionality.

Signed-off-by: Philipp Waller [email protected]

philippwaller avatar Mar 15 '22 15:03 philippwaller

Dear Core Team, do you have any feedback or change request regarding this PR? Thanks!

philippwaller avatar Mar 28 '22 09:03 philippwaller

Any updates on this? I would like to see this functionality, but seems like there was no reaction from the maintainers?

johanneskastl avatar Apr 05 '23 12:04 johanneskastl

I would be happy to revise the PR if the code is considered for future releases. Just let me know and I will make the necessary changes to ensure that the code is ready for integration.

philippwaller avatar Apr 07 '23 08:04 philippwaller

This looks good, can we rebase and get this PR up-to-date, so we can run some manual tests? also will be good if you have a sample ci pipeline to show this working

thanks for working on this

cpanato avatar May 04 '23 17:05 cpanato

@philippwaller if you need support ping me, I'm available for testing, code review or any other think that can be useful 🙈

mavimo avatar May 04 '23 18:05 mavimo

Any updates on this work? It would be great to see this feature merged. 🥇

lhriley avatar Aug 02 '23 00:08 lhriley

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 09 '23 01:11 github-actions[bot]

I will update this PR by end of next week. ✌️

philippwaller avatar Nov 09 '23 06:11 philippwaller

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 25 '23 01:12 github-actions[bot]

This PR was closed because it has been stalled for 10 days with no activity.

github-actions[bot] avatar Dec 31 '23 01:12 github-actions[bot]