chart-testing icon indicating copy to clipboard operation
chart-testing copied to clipboard

[bug] chart-testing requires optional maintainers field

Open caleb15 opened this issue 4 years ago • 2 comments

Is this a request for help?: No


Is this a BUG REPORT or FEATURE REQUEST? (choose one): BUG REPORT

Version of Helm and Kubernetes:

Helm version:

caleb-H110M-A:fifteen5-charts (add_more_helm_linting) $ helm version
version.BuildInfo{Version:"v3.2.4", GitCommit:"0ad800ef43d3b826f31a5ad8dfbb4fe05d143688", GitTreeState:"dirty", GoVersion:"go1.14.4"}

K8 version:

caleb-H110M-A:fifteen5-charts (add_more_helm_linting) $ docker run -it --rm --name ct --volume $(pwd):/data quay.io/helmpack/chart-testing sh -c "kubectl version"     
Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.4", GitCommit:"d360454c9bcd1634cf4cc52d1867af5491dc9c5f", GitTreeState:"clean", BuildDate:"2020-11-11T13:17:17Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"}
The connection to the server localhost:8080 was refused - did you specify the right host or port?

Ct version:

caleb-H110M-A:fifteen5-charts (add_more_helm_linting) $ docker run -it --rm --name ct --volume $(pwd):/data quay.io/helmpack/chart-testing sh -c "cd /data; ct version"                                   
Version:	 v3.3.1
Git commit:	 71d0e1e82c5c8b66ce4d9704426dc13b7075829d
Date:		 2020-11-30T20:10:04Z
License:	 Apache 2.0

What happened: ct complains about no maintainers

What you expected to happen: no complaint - as per the documentation the maintainers field is optional

How to reproduce it (as minimally and precisely as possible):

caleb-H110M-A:fifteen5-charts (add_more_helm_linting) $ helm create my-chart
caleb-H110M-A:fifteen5-charts (add_more_helm_linting) $ docker pull quay.io/helmpack/chart-testing:v3.3.1
caleb-H110M-A:fifteen5-charts (add_more_helm_linting*) $ docker run -it --rm --name ct --volume $(pwd):/data quay.io/helmpack/chart-testing sh -c "cd /data; ct lint --config .circleci/chart-testing.yaml"
Linting charts...
Version increment checking disabled.

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 my-chart => (version: "0.1.0", path: "my-chart")
------------------------------------------------------------------------------------------------------------------------
Linting chart 'my-chart => (version: "0.1.0", path: "my-chart")'
Validating /data/my-chart/Chart.yaml...
Validation success! 👍
Validating maintainers...
------------------------------------------------------------------------------------------------------------------------
 ✖︎ my-chart => (version: "0.1.0", path: "my-chart") > Chart doesn't have maintainers
------------------------------------------------------------------------------------------------------------------------
Error: Error linting charts: Error processing charts
Error linting charts: Error processing charts

The config is pretty much just:

chart-dirs:
  - my-chart
charts:
  - my-chart

Anything else we need to know:

caleb15 avatar Dec 04 '20 02:12 caleb15

Interestingly it looks like you have maintainers as optional in https://github.com/helm/chart-testing/blob/master/etc/chart_schema.yaml, so it's very odd that this error occurs.

caleb15 avatar Dec 04 '20 02:12 caleb15

You can add validate-maintainers: false to your ct.yaml

mr-onion-2 avatar Jan 05 '21 23:01 mr-onion-2

You can add validate-maintainers: false to your ct.yaml

This doesn't work with the latest version:

invalid config: no such rule: "validate-maintainers"

Workaround: ct lint --validate-maintainers=disable

gtirloni avatar Feb 23 '23 13:02 gtirloni

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 23 '23 01:11 github-actions[bot]

This issue was closed because it has been stalled for 5 days with no activity.

github-actions[bot] avatar Nov 28 '23 01:11 github-actions[bot]