acceptance-testing icon indicating copy to clipboard operation
acceptance-testing copied to clipboard

Kubernetes 1.16

Open jdolitsky opened this issue 4 years ago • 2 comments

We should test against 1.16 - i tried but the deployment of the test chart fails due to the new API versions/kinds used for Deployments

Essentially we should just need to update the helm chart have the new api types, only installing them on 1.16 and vice versa?

jdolitsky avatar Nov 22 '19 23:11 jdolitsky

I'm not sure I understood your question well but we should be able to do something like:

{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}

as taken from https://github.com/helm/helm/blob/84de17e7e5255e5033967f005d4b4c05c024317c/pkg/chartutil/create.go#L184

Although since we don't test with earlier versions than 1.14 we may be able to just change the apiVersion.

marckhouzam avatar Nov 23 '19 00:11 marckhouzam

@marckhouzam I feel we should update latest example to latest API versions, currently tests fails for all kubernetes versions which are beyond 1.15.

akashshinde avatar Jun 30 '20 04:06 akashshinde