[Bug] Import does *not* overwrite all existing tokens

[lemmy04]

I just imported a backup from my tablet onto my phone, and contrary to the warning it did not overwrite the existing tokens - it added the new ones at the end of the list, creating loads of duplicates, possible bad ones too if the token had been recreated since the last import.

[helloworld1]

Which format of backup are you using? I think the Json format should overwrite but not other formats.

[lemmy04]

I tried with both, both appended instead of overwriting.

[helloworld1]

Got it. This sounds like a behavior change by a change that allows the account with same issuer / account combo to be added. See https://github.com/helloworld1/FreeOTPPlus/issues/15

[PhilKes]

How about when importing Tokens via JSON we could check for every imported Token if there already is a Token in the DB that has the same issuer, label and secret combination. If yes, we overwrite the existing Token by keeping its internal id and using all other fields from the imported Token, if not, the new Token is inserted as usual. This would allow multiple Tokens for the same issuer + account (label) but would detect and overwrite actual duplicates when importing.

[helloworld1]

Yea, I think that's a reasonable way to deduplicate the token.

[lemmy04]

here's a fun bit: this weekend I tried again to copy my freeotp+ tokens from one device to the other, so i exported as json and imported on the other device, and this time around it did overwrite the existing tokens just fine o.0

[PhilKes]

@lemmy04 Thats probably due to the fact that when importing, the id (primary-key) is set to the index of the token in the JSON Token list. Therefore if you import a JSON once and then again, the second time all the same tokens will also have the same id and therefore will be correctly overwritten.