FreeOTPPlus icon indicating copy to clipboard operation
FreeOTPPlus copied to clipboard

[Feature request] Follow system settings regarding dark theme

Open Kernald opened this issue 4 years ago • 1 comments

Recent versions of Android (a few years) support automatically switching from a dark to a light theme depending on the time of the day (e.g. dark at night, light in the day). This makes apps like FreeOTP+ annoying to use, because while they support a dark theme, they're in the wrong state ~half of the time.

The current implementation seems to be following the battery saver setting only (unless the dark mode is explicitly enabled):

https://github.com/helloworld1/FreeOTPPlus/blob/f1f5a43dca9a78995882029965ac10884ed7915e/app/src/main/java/org/fedorahosted/freeotp/FreeOtpPlusApplication.kt#L13-L20

Using MODE_NIGHT_FOLLOW_SYSTEM instead would be more in line with user's expectations, I think.

Kernald avatar Aug 31 '21 12:08 Kernald

That's a good suggestion. Thanks.

helloworld1 avatar Sep 05 '21 04:09 helloworld1

I have changed to follow system theme https://github.com/helloworld1/FreeOTPPlus/commit/f04a154640789918c2975b30f7351e81a67c540e

helloworld1 avatar Dec 25 '22 19:12 helloworld1