FreeOTPPlus
FreeOTPPlus copied to clipboard
helloworld1
Change the background of icons in the dark mode
Please change the background of the icon to black for the dark mode (the same color as the background of the key / name frame). Many Thanks!
It is something that has been bothering me a little bit too. If the maintainers are ok, I can fix that. Here is what I'm thinking about. Current version:
What I can do:
Would that be ok?
The gray theme was added to improve the contrast of some dark icons. If you make the background too dark, some darker icons may not be visible. The correct fix would be to make background adaptable to the icon. https://github.com/helloworld1/FreeOTPPlus/issues/63
It is something that has been bothering me a little bit too. If the maintainers are ok, I can fix that. Here is what I'm thinking about. Current version:
Would that be ok?
Hi Carl-Philipp, yes, your proposal is perfect! That's exactly how I imagined it to be.
The gray theme was added to improve the contrast of some dark icons. If you make the background too dark, some darker icons may not be visible. The correct fix would be to make background adaptable to the icon. Gray is too noticeable. #63
I understand, but the icon can be changed. Black background looks more elegant
I have another suggestion - themes. I know it's a lot more work, but design is the second most important attribute besides functions. You can build in 3 themes - light, dark and custom with the options: text color, background color, primary color,... simply the most important colors to choose from
@helloworld1 I'm not a UI person, but it sounds like what you are describing would be with having different background depending on the actual icon. And I'm not sure that would be very attractive visually. My proposition was more around having the same background but a dark version of the icon if needed. That's how I have seen it done in other apps
I also think that the undepending black background for all icons is much nicer than an adaptive one. Everyone always has the possibility to choice an optimal icon
Yes it does look great if all icons are not using black elements. Unfortunately some icons are designed only for light theme. Maybe another option is fixing all those icons to use lighter gray so it's compatible with both light and dark theme.
Also, three dot button (edit/delete menu) is difficult to see in standard and dark modes. Three dots are displayed in black on dark gray. The button is hard to find.
Goddammit, this is over 2 years old now? I guess this won't be fixed. Too bad the dark theme can't be turned off anymore if the device itself is set to dark mode...
