planning-poker icon indicating copy to clipboard operation
planning-poker copied to clipboard

Bug with translation on Brave

Open dantecarlo opened this issue 2 years ago • 7 comments

When I access the web with the Brave browser, it does not detect the language correctly and does not enter the fallback correctly. I will download the code and try to recreate the error. I can also contribute to the Spanish translation.

error

dantecarlo avatar Jan 09 '24 19:01 dantecarlo

When I access the web with the Brave browser, it does not detect the language correctly and does not enter the fallback correctly. I will download the code and try to recreate the error. I can also contribute to the Spanish translation.

error

I cannot reproduce it on latest brave version 120.0.6099.199. Are you using the same version? and windows os?

hellomuthu23 avatar Jan 09 '24 21:01 hellomuthu23

I am using v 1.61.114 of Brave on a Windows 11 OS

dantecarlo avatar Jan 10 '24 00:01 dantecarlo

Hey @dantecarlo, I can't reproduce it too, I'm using the latest brave version Version 1.61.114 Chromium: 120.0.6099.199 (Official Build) (x86_64) on Sonoma 14.2.1. Can you please see if it's there some errors on inspect console or try in the anonymous window without any extensions?

vnscosta avatar Jan 10 '24 05:01 vnscosta

I got the error again. I opened an incognito tab and it happened again.

dantecarlo avatar Jan 23 '24 19:01 dantecarlo

image

dantecarlo avatar Jan 23 '24 19:01 dantecarlo

Hello,

I get the same bug on Firefox. But the browser doesn't matter, same thing on Chrome.

Actually, I think the problem is that i18n retrieves the browser language by default, but only 3 languages are available in the app: en-US, pt-BR and zh-Hant. My browers are in fr or fr-FR. In my local storage variables, i18n retains this values:

image

And so the language selection is empty:

image

If the language retrieved by the browser is not available, you should select en-US by default I guess?

SlyRaider avatar Mar 04 '24 11:03 SlyRaider

Hello, I ran through the same issue. Here is a PR to fix it: https://github.com/hellomuthu23/planning-poker/pull/101 thanks

lotmek avatar Jul 11 '24 21:07 lotmek