eks-rolling-update icon indicating copy to clipboard operation
eks-rolling-update copied to clipboard

Repo maintainers ?

Open jgournet opened this issue 1 year ago • 8 comments

Hi,

Is this project still maintained ? Last commit was a year ago, and there are several PR waiting to be merged. @crhuber maybe ?

Cheers,

jgournet avatar Jun 16 '23 02:06 jgournet

Hi

I've recently forked this repo and brought it up-to-date and published a docker image here. I'd be willing to merge PR's although the tests are broken there.

Find it here: https://github.com/deinstapel/eks-rolling-update

Cheers

martin31821 avatar Jun 16 '23 18:06 martin31821

:wave: @jgournet looking at the commit history and since all the previous contributors don't work at hello-fresh any more, I think it is safe to say, that this repo is unmaintained.

As @martin31821 already pointed out, we have a fork that works well with current EKS (we use it in production). If there is no update from the maintainers in this issue within the next days, we will create a hard fork, which we will maintain.

Right now there is still missing documentation (e.g. required k8s RBAC permissions for node draining) in our fork, which we will add within the next couple of days.

Jasper-Ben avatar Jun 16 '23 19:06 Jasper-Ben

@Jasper-Ben / @martin31821 : I guess the lack of answer is pretty clear :) Let me know if you go ahead and create a hard fork + merge all the pending PRs

in any case: thank you

jgournet avatar Jul 06 '23 23:07 jgournet

@jgournet I guess so :wink: We will go ahead with the hardfork and the README cleanup. Regarding the open PRs, I am not quite sure which of them are still relevant after the changes @martin31821 has done. Are you interested in any particular PR?

Jasper-Ben avatar Jul 07 '23 19:07 Jasper-Ben

@Jasper-Ben : thanks ! and yes, the PR I needed was: https://github.com/hellofresh/eks-rolling-update/pull/130 :)

jgournet avatar Jul 09 '23 21:07 jgournet

:wave: @jgournet

I haven't forgotten about you, just was a busy week and I didn't manage to move this any further. We should manage to get this rolling next week :slightly_smiling_face:

Jasper-Ben avatar Jul 14 '23 17:07 Jasper-Ben

https://github.com/deinstapel/eks-rolling-update was converted into a hardfork with its own issues and PRs

Jasper-Ben avatar Jul 20 '23 19:07 Jasper-Ben

:wave: @jgournet,

just letting you know, that I will recreate the work (again). Thought I need to create a new repo over a fork for enabling issues and PRs. turns out that it is just a setting in the forked repo :man_facepalming:. Unfortunately there is no option to mark a repo as fork after the fact, so recreating for visibility.

Jasper-Ben avatar Jul 20 '23 23:07 Jasper-Ben