eks-rolling-update icon indicating copy to clipboard operation
eks-rolling-update copied to clipboard

Published 20 hours ago • verified publisher icon hellofresh

updating deprecated command

Open crosbymichael1 opened this issue 1 year ago • 3 comments

When running this script I get the following warning:

Flag --delete-local-data has been deprecated, This option is deprecated and will be deleted. Use --delete-emptydir-data.

Updating the command now before its completely removed

crosbymichael1 avatar Aug 09 '22 05:08 crosbymichael1

@crhuber Can you please take a look at this one?

crosbymichael1 avatar Aug 09 '22 05:08 crosbymichael1

@chadlwilson are you able to review this please?

crosbymichael1 avatar Aug 13 '22 08:08 crosbymichael1

I'm not a hellofresh person, so don't have ability to run workflows or merge.

It's probably OK to do this now, since it seems the new flag was introduced in kubectl 1.20.0, but have to keep in mind it will break the tool when used with older kubectls, and kubectl versions have to be kept a single version away from the kubernetes API server version.

EKS seem to still have Kubernetes 1.18 and 1.19 and technically kubectl 1.20 is not guaranteed to work on 1.18, however 1.18 ended EKS support in March 2022, and 1.19 recently, so I think this is probably OK. Not sure if they have started force-migrating clusters yet.

chadlwilson avatar Aug 13 '22 08:08 chadlwilson