ansible-sssd-ldap icon indicating copy to clipboard operation
ansible-sssd-ldap copied to clipboard

Add certificate configuration option

Open orbatschow opened this issue 5 years ago • 2 comments

Adding the following variables:

ldap_tls_cacert

I also included a new file to make the role work in Debian. This can however not automatically be tested, as molecule only supports CentOS and Ubuntu as far as I know. - It works on Debian Buster though.

I think we can merge this and flag Debian as not tested (if at all).

orbatschow avatar Sep 03 '19 09:09 orbatschow

@orbatschow great work. I would appreciate if it was merged, as I need this for Debian systems.

Code seems good for me. If you add tests for Debian, then I think maintainer wouldn't hesitate to merge.

Test can be added to molecule.yml config (https://github.com/hellofresh/ansible-sssd-ldap/blob/master/molecule/default/molecule.yml). I suggest usage of image alexdzyoba/debian-systemd:9 (https://github.com/alexdzyoba/docker-debian-systemd) and configuration like ubuntu-xenial.

elcomtik avatar Dec 06 '19 12:12 elcomtik

@elcomtik thank you!

The link you provided only covers Debian 9. As the current Debian version is 10 and this image is a modification to the original image I doubt that it will make sense to test it with a basically different image (https://github.com/alexdzyoba/docker-debian-systemd is also more than two years old).

Furthermore, this repository does not seem to be maintained anymore. (Last commit is almost 1 year ago.)

Maybe @antonu17 can provide some information about the status of this repo.

orbatschow avatar Feb 13 '20 13:02 orbatschow