Utilities icon indicating copy to clipboard operation
Utilities copied to clipboard

Proccesses.app Weird disk partition

Open louies0623 opened this issue 1 year ago • 7 comments

20230916_185703 20230916_185641 Too many disk partitions appear, as the picture.

louies0623 avatar Sep 16 '23 14:09 louies0623

Not all of these are partitions indeed. @Hierosme can you have a look please? Why does the Processes app even deal with partitions at all?

probonopd avatar Sep 17 '23 17:09 probonopd

Hello,

i'm in travel yet i cant touch my IDE before next week.

Why does the Processes app even deal with partitions at all?

As you havent say to me, that a Activity Monitor clone, the original Activity Monitor got it Disk Usage tab, then the Proccesses.app got...

image

About the anormal disk partition number: The trouble is psutil under FreeBSD specific , that trouble do not exist under GNU/Linux...

https://github.com/giampaolo/psutil/issues/906 https://github.com/giampaolo/psutil/blob/77e5b7445748d30d22c0e3b2e651414da96a88b4/psutil/_psbsd.py#L366

Here the code where i use psutil.disk_partitions(all=False): https://github.com/helloSystem/Utilities/blob/b3bd91c097d91954bbe8bb5e84c9ab5f81db67e7/Utilities/Processes.app/Resources/worker_psutil.py#L63

Yes that a bug on our data source ....

Hierosme avatar Sep 19 '23 12:09 Hierosme

i can a a filter easilly and force that match with df and not df -a.

I open a PR for a workarround soon.

Hierosme avatar Sep 19 '23 12:09 Hierosme

i have put micro filter inside the https://github.com/helloSystem/Utilities/pull/209

It consist to consider to display only pratition it got more of one FS block size. For speed up i have consider block to 4096.

Actually df and df -a return same result under FreeBSD, that is our root cause.

A good way can be to display only certain type of file system (in cse List to do), yet that is block size filter. Please can you retry and ask me if the result is more close of what you expect ? @louies0623 @probonopd

Hierosme avatar Sep 26 '23 07:09 Hierosme

I don't understand this, maybe @probonopd can

louies0623 avatar Oct 02 '23 13:10 louies0623

https://github.com/helloSystem/Utilities/pull/209 is merged. So, is it working better now @louies0623?

probonopd avatar Oct 03 '23 07:10 probonopd

Personally i dont like the workarround.

If df -a under FreeBSD work like that , it certinky because under FreeBSD that is supposate to be display like that.

From my point it should be let like FreeBSD want, then filter nothing. In general i like say Not my fault here that a hight way to a Not my fault :)

Hierosme avatar Oct 04 '23 13:10 Hierosme