helloSystem
Non-spatial mode broken
Opens each folder in a new window even if Spatial model is off.
Can this be reproduced?
Which commit introduced this bug? Possible need to do git bisect.
This can be reproduced. I activated non-spatial mode and I still had new windows for each folder. It did change the window some so that I had navigation controls on the window, which those worked fine.
It had worked once. I think I must have broken it accidentally (and not noticed since I use Spatial).
We need to figure out which commit broke it by using git bisect...
I may have some time today I will check it out and see what I can find. I will update later if I find anything.
On Sun, Nov 28, 2021, 08:57 probonopd @.***> wrote:
It had worked once. I think I must have broken it accidentally. We need to figure out which commit broke it by using git bisect...
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/helloSystem/Filer/issues/134#issuecomment-981117571, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQ5WCTWCJISAGEMSZQ6AETUOJNOZANCNFSM5GSGFTCQ .
I would not be entirely surprised if it started to break around https://github.com/helloSystem/Filer/commit/1c60345a561f33e7617a0c4de22523435a65967a. Possibly we need to use some if (isSpatialMode()) {...}.