Jay Michalska comments

Results 15 comments of


                                            Jay Michalska

New frontend: Combine the two text boxes when reviewing SRs

Worth noting, GitHub and Gitea only allow you to close a PR from that box, merging a PR doesn't have the option to leave a comment besides the merge commit...

[production][request#request_action_changes] undefined method `where' for nil:NilClass @action = @actions.where(id: params['id'].to_i).fi...

I don't see us setting `@actions` for that controller action, there is no before_action that would set `@actions` that is applied to this controller action either. How is that supposed...

[production][request#request_action_changes] undefined method `where' for nil:NilClass @action = @actions.where(id: params['id'].to_i).fi...

Oh, I missed that, because the line is so long.

Icons instead of text for build results

Related to #4686

"Build Service Notification" mail needs a better subject line

For some more context, those are `Event::Relationship*` emails, they are using the default subject line. Users started receiving them because of the changed default in the reference server.