helix icon indicating copy to clipboard operation
helix copied to clipboard

Handle window/showMessage and display it bellow status line

Open ayoub-benali opened this issue 2 years ago • 3 comments

This feature is also hidden behind the display-messages setting which is used for displaying Progress.

I don't think it make sense to create separate setting for this feature as I don't expect a server to send both Progress and window/showMessage but I can add one if you prefer.

Metals relies on this notification for providing info about the build and is configured here.

Hopefully this will be useful for other language servers.

Here is an example (bottom left) for the message sent by Metals.

Untitled

Fix https://github.com/helix-editor/helix/issues/5524

ayoub-benali avatar Jan 14 '23 20:01 ayoub-benali

What should be the new setting name ? Progress is already using a missleading name. should I introduce a breaking change and make progress be controlled with 'display-progress-message' while show message would use the current name ?

ayoub-benali avatar Jan 16 '23 16:01 ayoub-benali

Yeah I think you're right about the names. Ideally we should avoid breaking changes but I think progress messages would be better as display-progress-messages and showMessage messages as display-messages.

the-mikedavis avatar Jan 16 '23 17:01 the-mikedavis

@the-mikedavis So I made the change but I think now a R-breaking-change label should be added to the PR, I couldn't do it myself.

ayoub-benali avatar Jan 17 '23 11:01 ayoub-benali

@the-mikedavis Is the popup support a must have for this PR or could we added it later depending on the user requests ? I think statusline is already better than nothing, since this LSP notification isn't even supported now

ayoub-benali avatar Jan 19 '23 10:01 ayoub-benali

Can we include this into the next release?

igor-ramazanov avatar Sep 07 '23 06:09 igor-ramazanov

(sorry, I thought I was in another PR - still, I really do want this :) would make it a bit easier to use Helix as a client for testing new LSPs 👍🏻)

AlexanderBrevig avatar Mar 05 '24 14:03 AlexanderBrevig