helix icon indicating copy to clipboard operation
helix copied to clipboard

Buffer navigation through clicking on bufferline

Open imelinonkaneko opened this issue 3 years ago • 3 comments

Closes #4942

imelinonkaneko avatar Dec 07 '22 12:12 imelinonkaneko

This is not very efficient because you're iterating over the line and calculating offsets each time. This should probably be precomputed

archseer avatar Dec 24 '22 04:12 archseer

I thought that iterating and calculating it on click would be an easier option and that the slight inefficiency would be fine since the rendering code iterates over the bufferline in the same way every time the editor is rendered again and this does it only once when you actually click on the bufferline. I did not like storing data that is constantly changing and is used very rarely. If you think otherwise, you can probably just close this as #5335 seems to do it with precomputed widths.

imelinonkaneko avatar Jan 10 '23 18:01 imelinonkaneko

It would be nice if this could be reviewed again or looked at. The feature is useful and a direction on implementation before yet another pull request is made would be nice to know. Unless of course a pull request in the queue is sufficient.

AddictArts avatar May 05 '23 15:05 AddictArts

Closing this as its quite stale.The bufferline or mouse support are also not a priority. Thank you for contributing!

pascalkuthe avatar Apr 08 '24 01:04 pascalkuthe